Marcus Lindblom Sonestedt
2017-02-08 17:25:07 UTC
Hello again,
I also noticed that I had added some unnecessary reinterpret_cast-s in the
pull request a few months ago.
This concerns initMethod and exitMethod
in TemplateFieldContainerBase_cpp.txt:
&@!Classname!@::initMethod,
&@!Classname!@::exitMethod,
I assumed it was a VS2013 thing but noticed just now that the function
signature had changed instead (an arg was added), so no reinterret_cast is
necessary.
I've reverted here and it compiles just fine, so it can be done on master
too.
I suppose our initMethod's just ignored the arg on the stack, and
double-registration of enter/leave functors is not a problem.
I also noticed that I had added some unnecessary reinterpret_cast-s in the
pull request a few months ago.
This concerns initMethod and exitMethod
in TemplateFieldContainerBase_cpp.txt:
&@!Classname!@::initMethod,
&@!Classname!@::exitMethod,
I assumed it was a VS2013 thing but noticed just now that the function
signature had changed instead (an arg was added), so no reinterret_cast is
necessary.
I've reverted here and it compiles just fine, so it can be done on master
too.
I suppose our initMethod's just ignored the arg on the stack, and
double-registration of enter/leave functors is not a problem.
--
Med vÀnliga hÀlsningar,
Marcus Lindblom Sonestedt
*Systemarkitekt*
*BIT ADDICT *- Passion för utveckling
+46 (0)706 43 63 28
***@bitaddict.se
www.bitaddict.se
Med vÀnliga hÀlsningar,
Marcus Lindblom Sonestedt
*Systemarkitekt*
*BIT ADDICT *- Passion för utveckling
+46 (0)706 43 63 28
***@bitaddict.se
www.bitaddict.se